refactor: changes to close ELY-2595,2596,2597,2603,2605,2606,2607 #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjuma
requested changes
Oct 6, 2023
There was a problem hiding this comment.
Hi @abhishek-nigam, welcome to the WildFly Elytron project! Thank you very much for your contribution!
It's good practice to have one commit per ELY issue (this makes it easier for us to review and verify changes).
Would you be able to update this PR so that it has 7 commits (one for each of the ELY issues you have listed in the description)? If you prefer, another option would be to submit a separate PR for each issue.
There's also a useful post here on how to split a commit in case it helps:
https://emmanuelbernard.com/blog/2014/04/14/split-a-commit-in-two-with-git/
Feel free to let us know if you have any questions about this.
Thanks!
abhishek-nigam
force-pushed
the
refactoring-1
branch
3 times, most recently
from
42ca09c to
5921b39
Compare
|
Hi @fjuma Thank you for welcoming my contribution. As instructed, I have split up my commit into 7 commits in which each tackles an ELY issue. Please let me know if any other change is required from my end, I'll be happy to do them. Also, I want to mention that I haven't been able to successfully run Here is the error output I'm getting: |
|
Hi @abhishek-nigam |
|
Hi @PrarthonaPaul , I just went over the guide. I have installed Java 11 using Sdkman and I am running WSL (Ubuntu) on Windows 11. Here are the points I checked:
In the guide I wasn't able to successfully run It gives me the following output I'm guess it might be since I haven't installed Java using Ubuntu's packages manager. I'm not sure why I'm getting the error I posted, also the Github action too just failed. However, I do notice that in it, it was able to fail at a later stage/test where it was failing on my local. I'm not sure what's happening 🥵 Do you have an idea? |
|
Hi @abhishek-nigam when you run |
|
Hi @PrarthonaPaul , Yes, I get the following output when I run Is it as expected? Thank you for the help :) |
|
It seems right. Are your tests still failing? |
|
@abhishek-nigam You do not need to setup JBOSS MVN repository, the project can be build without it. Are you building the project from the command line or with IDE? |
|
Hi @PrarthonaPaul Unfortunely yes, I do have maven installed and JAVA_HOME environment variable is set and it's also present in my PATH. |
abhishek-nigam
force-pushed
the
refactoring-1
branch
2 times, most recently
from
5bdd4df to
43bed9f
Compare
|
Hi, I have gotten further on this. There were two issues that I overcame:
Now, it seems that on Github Actions workflow has passed. On my native Ubuntu setup, I've passed the tests that were failing earlier but now getting the following error in HTTP OIDC step: in which I note the lines I'd like to mention that I'm getting the above even on 2.x branch which doesn't have my changes. So, I'm guessing this is related to local environment and my changes are okay. |
|
Hi @abhishek-nigam, the HTTP OIDC tests require docker to be installed and running in your environment. |
|
Thank you @fjuma and all maintainers! Happy to see this output finally Build is successful! |
|
That's awesome, @abhishek-nigam, glad you were able to build successfully! |
fjuma
requested changes
Oct 10, 2023
| @@ -445,7 +445,7 @@ private void printSummary (String keystorePassword, String salt, int iterationCo | |||
| if (keystorePassword != null) { | |||
| password = keystorePassword; | |||
| if (salt != null && iterationCount > -1) { | |||
| password = keystorePassword.startsWith("MASK-") ? keystorePassword + ";" + salt + ";" + String.valueOf(iterationCount) | |||
| password = keystorePassword.startsWith("MASK-") ? keystorePassword + ";" + salt + ";" + iterationCount | |||
There was a problem hiding this comment.
GitHub is showing a conflict in this file. Let us know if you need help with resolving the conflict.
There was a problem hiding this comment.
Oh, yes. I just resolved the conflict. Please let me know if any other changes are required!
There was a problem hiding this comment.
Also, as an inside, I was wondering if it would be good to add dev containers support in the project. In my understanding, it would make it trivial for any developer to get the environment set up for the project
There was a problem hiding this comment.
That's an interesting suggestion. We'll look into that some more to see if it makes sense.
abhishek-nigam
force-pushed
the
refactoring-1
branch
from
43bed9f to
42f4c84
Compare
fjuma
approved these changes
Oct 11, 2023
|
Thank you all! Happy about this :) |
|
@abhishek-nigam just a last minor detail, can you please change the title of the commits to not include the |
abhishek-nigam
force-pushed
the
refactoring-1
branch
from
42f4c84 to
b82cfcf
Compare
|
@Skyllarr Sure, I have made the edits now. I wanted to ask if should I start each commit message title with a capital letter or if the current one is fine. Thank you! |
|
@abhishek-nigam Actually I'm sorry I was not clear in my previous message. Each issue has to have an issue number at the beginning, but without the Thank you for understanding! |
…ability This closes ticket https://issues.redhat.com/browse/ELY-2603
This add missing @OverRide annotation on dispose() method of class FileSystemSecurityRealm This closes ticket https://issues.redhat.com/browse/ELY-2596
…sing String.valueOf() This closes ticket https://issues.redhat.com/browse/ELY-2607
This makes data members ElytronToolExitStatus_unrecognizedCommand & ElytronToolExitStatus_OK final (they're already declared as public static) since their values don't change. This closes ticket https://issues.redhat.com/browse/ELY-2606
This makes data members ACTION_NOT_DEFINED & ALIAS_NOT_FOUND final (they're already declared as public static) since their values don't change. This closes ticket https://issues.redhat.com/browse/ELY-2605
This removes unused parameter identityToWrite from requiredVersion method signature. This closes ticket https://issues.redhat.com/browse/ELY-2595
This merges an if statement with it's enclosing if statement to increase readability. This closes ticket https://issues.redhat.com/browse/ELY-2597
abhishek-nigam
force-pushed
the
refactoring-1
branch
from
b82cfcf to
4c62141
Compare
|
Hi @Skyllarr No worries! I have made the edits now |
Skyllarr
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some refactoring changes to close the following tickets: